Skip to content
This repository was archived by the owner on Apr 3, 2025. It is now read-only.

Conversation

@seanohair22
Copy link
Contributor

PR Checklist

Author Mandatory (to be filled by PR Author/Submitter)

CODE MAINTAINABILITY

  • Commit Message meets guidelines as indicated in the URL*
  • Tests for the changes have been added (required for bug fixes / features). If not, state why not
  • Added labels (these are git labels such as bug or enhancement)
  • For any API changes or service changes, updates to the documentation were made (Swagger APIs & GitHub Docs). If not, state why not
  • Every commit is a single defect fix and does not mix feature addition or changes*

What are the steps to test this PR contribution?

How does a reviewer know it works?

  • If the build builds correctly in the integration test or the make docker build target.

Are there any special instructions beyond standard workflow?

Maintainer Mandatory (to be filled by PR Reviewer/Approving Maintainer)

QUALITY CHECKS

  • Quality of code (At least one should be checked as applicable)*
    • Commit Message meets guidelines
    • Code copyright is correct
    • PR changes adhere to industry practices and standards as well as domain or language specific anti-patterns
    • Adopted domain specific coding standards (Go Coding Standards)
    • Code is adequately commented and documented
    • Confusing logic is explained in comments
    • Error and exception code paths implemented correctly
    • Tracing output are minimized and logic
  • Test coverage shows adequate coverage with required CI functional tests pass on all supported platforms*
  • Static code scan report shows zero critical issues*

Other information

Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
@seanohair22 seanohair22 added the dependencies Pull requests that update a dependency file label Jan 3, 2025
@seanohair22 seanohair22 self-assigned this Jan 3, 2025
@seanohair22 seanohair22 requested a review from a team as a code owner January 3, 2025 17:58
Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanohair22 seanohair22 merged commit 7960785 into intel:main Jan 3, 2025
7 checks passed
@seanohair22 seanohair22 deleted the build-fix-ca-certs branch January 3, 2025 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants